diff options
author | vnugent <public@vaughnnugent.com> | 2024-03-10 16:46:50 -0400 |
---|---|---|
committer | vnugent <public@vaughnnugent.com> | 2024-03-10 16:46:50 -0400 |
commit | e5bb0ee302e789cb96e7ecfe839cbbcc8e3fd5d7 (patch) | |
tree | 6f4d824eaea0f4c433f98c0685bf66c06b30e16a /lib/VNLib.Data.Caching.ObjectCache | |
parent | 6b87785026ca57d6f41cff87ddbd066362f3cacc (diff) |
Squashed commit of the following:
commit 2f7565976472f0f056db60520bf253a776112c10
Merge: 323ff67 6b87785
Author: vnugent <public@vaughnnugent.com>
Date: Sun Mar 10 16:45:23 2024 -0400
merge master
commit 323ff67badfc46ad638d75f059d60d9425ccb2fa
Author: vnugent <public@vaughnnugent.com>
Date: Sun Mar 10 15:50:07 2024 -0400
ci(server): Conainerize and add vncache server packages
commit 5d4192880654fd6e00e587814169415b42621327
Author: vnugent <public@vaughnnugent.com>
Date: Sat Mar 9 19:13:21 2024 -0500
chore: #2 Minor fixes and polish before release
commit a4b3504bb891829074d1efde0433eae010862181
Author: vnugent <public@vaughnnugent.com>
Date: Sat Mar 9 16:30:44 2024 -0500
package updates
commit 4d8cfc10382105b0acbd94df93ad3d05ff91db54
Author: vnugent <public@vaughnnugent.com>
Date: Wed Mar 6 21:30:58 2024 -0500
refactor: #2 Centralize server state, default discovery endpoints & more
commit 016a96a80cce025a86c6cf26707738f6a2eb2658
Author: vnugent <public@vaughnnugent.com>
Date: Thu Feb 29 21:22:38 2024 -0500
feat: add future support for memory diagnostics, and some docs
commit 456ead9bc8b0f61357bae93152ad0403c4940101
Author: vnugent <public@vaughnnugent.com>
Date: Tue Feb 13 14:46:35 2024 -0500
fix: #1 shared cluster index on linux & latested core updates
commit a481d63f964a5d5204cac2e95141f37f9a28d573
Author: vnugent <public@vaughnnugent.com>
Date: Tue Jan 23 15:43:50 2024 -0500
cache extension api tweaks
Diffstat (limited to 'lib/VNLib.Data.Caching.ObjectCache')
-rw-r--r-- | lib/VNLib.Data.Caching.ObjectCache/src/BlobCacheTable.cs | 15 | ||||
-rw-r--r-- | lib/VNLib.Data.Caching.ObjectCache/src/ICacheEntryMemoryManager.cs | 8 |
2 files changed, 8 insertions, 15 deletions
diff --git a/lib/VNLib.Data.Caching.ObjectCache/src/BlobCacheTable.cs b/lib/VNLib.Data.Caching.ObjectCache/src/BlobCacheTable.cs index 8270f2f..789448d 100644 --- a/lib/VNLib.Data.Caching.ObjectCache/src/BlobCacheTable.cs +++ b/lib/VNLib.Data.Caching.ObjectCache/src/BlobCacheTable.cs @@ -1,5 +1,5 @@ /* -* Copyright (c) 2023 Vaughn Nugent +* Copyright (c) 2024 Vaughn Nugent * * Library: VNLib * Package: VNLib.Data.Caching.ObjectCache @@ -66,12 +66,8 @@ namespace VNLib.Data.Caching.ObjectCache /// <exception cref="ArgumentException"></exception> public BlobCacheTable(uint tableSize, uint bucketSize, ICacheMemoryManagerFactory factory, IPersistantCacheStore? persistantCache) { - _ = factory ?? throw new ArgumentNullException(nameof(factory)); - - if(tableSize == 0) - { - throw new ArgumentException("Cache table must have atleast 1 bucket"); - } + ArgumentNullException.ThrowIfNull(factory); + ArgumentOutOfRangeException.ThrowIfZero(tableSize); //Init bucket table _tableSize = tableSize; @@ -106,10 +102,7 @@ namespace VNLib.Data.Caching.ObjectCache private uint FastGetBucketIndexFromId(ReadOnlySpan<char> objectId) { - if (objectId.Length < 4) - { - throw new ArgumentException("Object id must be larger than 3 characters"); - } + ArgumentOutOfRangeException.ThrowIfLessThan(objectId.Length, 4, nameof(objectId)); Span<byte> buffer = stackalloc byte[4]; diff --git a/lib/VNLib.Data.Caching.ObjectCache/src/ICacheEntryMemoryManager.cs b/lib/VNLib.Data.Caching.ObjectCache/src/ICacheEntryMemoryManager.cs index dffbfa2..dd57931 100644 --- a/lib/VNLib.Data.Caching.ObjectCache/src/ICacheEntryMemoryManager.cs +++ b/lib/VNLib.Data.Caching.ObjectCache/src/ICacheEntryMemoryManager.cs @@ -1,5 +1,5 @@ /* -* Copyright (c) 2023 Vaughn Nugent +* Copyright (c) 2024 Vaughn Nugent * * Library: VNLib * Package: VNLib.Data.Caching.ObjectCache @@ -57,9 +57,9 @@ namespace VNLib.Data.Caching /// Pins the handle to the specified offset and returns a /// <see cref="MemoryHandle"/> to the pinned memory block. /// </summary> - /// <param name="handle"></param> - /// <param name="offset"></param> - /// <returns></returns> + /// <param name="handle">A referrence to the existing handle</param> + /// <param name="offset">The number of bytes from the base to offset the returned pointer</param> + /// <returns>A memory handle pointing to the first byte in the segment given by the offset</returns> MemoryHandle PinHandle(object handle, int offset); /// <summary> |