aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLibravatar Michael Jurkoic <mjjurkoic@gmail.com>2024-04-14 23:04:43 -0500
committerLibravatar Michael Jurkoic <mjjurkoic@gmail.com>2024-04-14 23:04:43 -0500
commitc0df21229d4c79bc94dc85a43b798bf0676cb2f1 (patch)
tree1dce8e8cf655e1eb1f4ce307a4272a33aaaa4154
parent27f42557a5f6d8a5f1b9a16431edca8129261953 (diff)
Take send out of try-catch
The client::IWebSocketClient::send method should catch errors and return false if anything goes wrong.
-rw-r--r--src/nostr_service.cpp53
1 files changed, 23 insertions, 30 deletions
diff --git a/src/nostr_service.cpp b/src/nostr_service.cpp
index 8af1e20..3dbff62 100644
--- a/src/nostr_service.cpp
+++ b/src/nostr_service.cpp
@@ -231,38 +231,31 @@ vector<shared_ptr<Event>> NostrService::queryRelays(shared_ptr<Filters> filters)
promise<tuple<string, bool>> eosePromise;
requestFutures.push_back(move(eosePromise.get_future()));
- try {
- auto [uri, success] = this->_client->send(
- request,
- relay,
- [this, &relay, &events, &eosePromise](string payload)
- {
- this->onSubscriptionMessage(
- payload,
- [&events](const string&, shared_ptr<Event> event)
- {
- events.push_back(event);
- },
- [relay, &eosePromise](const string&)
- {
- eosePromise.set_value(make_tuple(relay, true));
- },
- [relay, &eosePromise](const string&, const string&)
- {
- eosePromise.set_value(make_tuple(relay, false));
- });
- });
-
- if (!success)
+ auto [uri, success] = this->_client->send(
+ request,
+ relay,
+ [this, &relay, &events, &eosePromise](string payload)
{
- PLOG_WARNING << "Failed to send query to relay: " << relay;
- eosePromise.set_value(make_tuple(uri, false));
- }
- }
- catch (const exception& e)
+ this->onSubscriptionMessage(
+ payload,
+ [&events](const string&, shared_ptr<Event> event)
+ {
+ events.push_back(event);
+ },
+ [relay, &eosePromise](const string&)
+ {
+ eosePromise.set_value(make_tuple(relay, true));
+ },
+ [relay, &eosePromise](const string&, const string&)
+ {
+ eosePromise.set_value(make_tuple(relay, false));
+ });
+ });
+
+ if (!success)
{
- PLOG_ERROR << "Failed to send query to " << relay << ": " << e.what();
- eosePromise.set_value(make_tuple(relay, false));
+ PLOG_WARNING << "Failed to send query to relay: " << relay;
+ eosePromise.set_value(make_tuple(uri, false));
}
}